Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: more styleguide #1250

Merged
merged 3 commits into from
Dec 25, 2024
Merged

docs: more styleguide #1250

merged 3 commits into from
Dec 25, 2024

Conversation

verytactical
Copy link
Contributor

PR to keep other styleguide changes as long as I keep remembering them

@verytactical verytactical requested a review from a team as a code owner December 24, 2024 19:51
novusnota
novusnota reviewed Dec 24, 2024
View reviewed changes
Copy link
Member

@novusnota novusnota left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be cool if you could encode some of the rules from the list as our ESLint rules

@anton-trunov anton-trunov merged commit 402c86d into main Dec 25, 2024
17 checks passed
@anton-trunov anton-trunov deleted the more-styleguide branch December 25, 2024 07:39
@anton-trunov anton-trunov self-assigned this Dec 25, 2024
@anton-trunov anton-trunov added this to the v1.6.0 milestone Dec 25, 2024
@anton-trunov anton-trunov added the scope: dev-docs Internal documentation of the Tact compiler and the repository. (dev-docs/) label Dec 25, 2024
xpyctumo pushed a commit that referenced this pull request Dec 26, 2024
@verytactical @xpyctum
chore(docs): more TypeScript styleguide (#1250)
6b71ddf
@anton-trunov anton-trunov mentioned this pull request Dec 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novusnota novusnota novusnota left review comments

@anton-trunov anton-trunov anton-trunov approved these changes

Assignees

@anton-trunov anton-trunov

Labels
scope: dev-docs Internal documentation of the Tact compiler and the repository. (dev-docs/)
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@verytactical @anton-trunov @novusnota