Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): variable integer serialization types #1274

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(docs): variable integer serialization types #1274

wants to merge 1 commit into from

Conversation

novusnota
Copy link
Member

Slowly getting back in the saddle.

Issue

Closes #1252.

Checklist

  • I have updated CHANGELOG.md
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@novusnota novusnota added this to the Doc: 2024-12 milestone Dec 30, 2024
@novusnota novusnota requested a review from a team as a code owner December 30, 2024 22:53
anton-trunov
anton-trunov requested changes Dec 31, 2024
View reviewed changes
docs/src/content/docs/book/integers.mdx
@@ -158,6 +158,47 @@ struct Scrooge {
}
```

### Variable integer types {#serialization-varint}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be merged with the coins description, since it's just an alias to varuint16

@anton-trunov
Copy link
Member

anton-trunov commented Jan 1, 2025 •
edited
Loading

The map page should also mention which annotations are supported for key and value types:

Since TVM natively supports only maps with fixed-width keys, you can only use the uint and int serialization annotations for map keys...

See #1275

@novusnota
Copy link
Member Author

novusnota commented Jan 3, 2025 •
edited
Loading

The map page should also mention which annotations are supported for key and value types

Got it.

UPD: Was stuck for a bit, now close to resolving this, compilation report and many other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Doc: 2024-12
Development

Successfully merging this pull request may close these issues.

Document varint16, varint32, varuint16, varuint32 storage annotations
2 participants
@novusnota @anton-trunov