Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not allow variable width integer map key types #1276

Merged
merged 2 commits into from
Jan 1, 2025
Merged

fix: do not allow variable width integer map key types #1276

merged 2 commits into from
Jan 1, 2025

Conversation

anton-trunov
Copy link
Member

Issue

Closes #1275.

Checklist

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@anton-trunov anton-trunov added this to the v1.6.0 milestone Jan 1, 2025
@anton-trunov anton-trunov requested a review from a team as a code owner January 1, 2025 12:30
@anton-trunov anton-trunov self-assigned this Jan 1, 2025
@anton-trunov anton-trunov merged commit 06cb9f4 into main Jan 1, 2025
17 checks passed
@anton-trunov anton-trunov deleted the forbid-varint-map-key-types branch January 1, 2025 12:53
xpyctumo pushed a commit that referenced this pull request Jan 13, 2025
@anton-trunov @xpyctumo
fix: do not allow variable width integer map key types (#1276)
9ba7abb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

Reject map types with variable length integer keys
1 participant
@anton-trunov