Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Value type #1277

Merged
merged 12 commits into from
Jan 13, 2025
Merged

refactor: Value type #1277

merged 12 commits into from
Jan 13, 2025
+1,647 −944

Conversation

jeshecdom
Copy link
Contributor

Issue

Closes #1190.

Checklist

  • I have updated CHANGELOG.md
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@jeshecdom jeshecdom requested a review from a team as a code owner January 1, 2025 14:10
verytactical
verytactical reviewed Jan 9, 2025
View reviewed changes
src/grammar/ast.ts Outdated Show resolved Hide resolved
anton-trunov
anton-trunov reviewed Jan 9, 2025
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only reviewed the PR superficially, feel free to argue against the suggestions

src/grammar/ast.ts Show resolved Hide resolved
src/grammar/ast.ts Show resolved Hide resolved
src/optimizer/util.ts Show resolved Hide resolved
src/types/resolveExpression.ts Outdated Show resolved Hide resolved
src/types/types.ts Show resolved Hide resolved
@anton-trunov anton-trunov added this to the v1.6.0 milestone Jan 13, 2025
@verytactical verytactical merged commit ed30e4c into main Jan 13, 2025
17 checks passed
@verytactical verytactical deleted the value-type branch January 13, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@verytactical verytactical verytactical left review comments

@anton-trunov anton-trunov anton-trunov approved these changes

Assignees

@verytactical verytactical

Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

Refactor Value type
3 participants
@jeshecdom @anton-trunov @verytactical