Support for trailing comma

[vitorpy]

Closes #28.
Based on abandoned PR #49.

[anton-trunov]

Hi @vitorpy, thanks for reviving that PR! You made the PR to be a draft, any additional things need to be done here?

[anton-trunov]

btw, you probably want to remove src/test/features/serialization-2.tact from your PR -- it's just some unrelated whitespace changes

[vitorpy]

Hi @vitorpy, thanks for reviving that PR! You made the PR to be a draft, any additional things need to be done here?

Hey, I'm going to add support for trailing commas on function arguments lists as well.

[anton-trunov]

I left a few suggestions that should be pretty easy to fix. Looking forward to having the trailing comma feature in the language!

[anton-trunov]

Please add also the corresponding entry in CHANGELOG.md (the Changed section)

[anton-trunov]

Awesome stuff! Thanks for all the quick fixes. Just one tiny change and we are good to go

[anton-trunov]

I just added this PR to the v1.3.0 milestone so we will make it available in the very next Tact release

[vitorpy]

I just added this PR to the v1.3.0 milestone so we will make it available in the very next Tact release

Thanks! That was fun! I'll see if I grab another issue 😃

[anton-trunov]

Thanks! That was fun! I'll see if I grab another issue 😃

@vitorpy By all means! If you decide to do it, it would be nice if you outlined your solution before going for it, just to make sure we are on the same page and to make the code review process a faster and smoother experience.

[vitorpy]

Thanks! That was fun! I'll see if I grab another issue 😃

@vitorpy By all means! If you decide to do it, it would be nice if you outlined your solution before going for it, just to make sure we are on the same page and to make the code review process a faster and smoother experience.

Will do. This one I went directly as I saw the old PR and it seemed like a good way to get to know the code base a little without too much trouble. Fixed the test case - thanks for the review!

[anton-trunov]

CI shows that some tests are failing

You can see here how to run it locally:
https://github.com/tact-lang/tact/blob/main/.github/workflows/tact.yml#L35-L38

[anton-trunov]

Sorry for all the back and forth, I think I finally got the hang of writing and debugging tests for tact. Thanks!

Hey @vitorpy, no worries at all! Thank you for bringing this feature to Tact and helping to make the implementation more robust

[anton-trunov]

CI is red unfortunately

[vitorpy]

@anton-trunov I'm kinda stuck on why case-0 is not throwing. Could you give me some pointers on how to progress?

[anton-trunov]

@vitorpy Thank you for your contribution! This qualifies for the Tact contributor SBT: https://society.ton.org/contribute-to-tact-compiler. I'll just need your TON wallet address to issue the token

[vitorpy]

Awesome! I'll try to keep the contributions going.

UQAz6vmh0aKPSH5dJHsfHI8YQH55oLeuWMz4eQkr4ZjS-aG6

[anton-trunov]

SBT issued! Hope to see more things from you 👍