Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for |= &= and ^= #350

Merged
merged 6 commits into from
Jun 8, 2024
Merged

feat: add support for |= &= and ^= #350

merged 6 commits into from
Jun 8, 2024

Conversation

Alejandbel
Copy link
Contributor

@Alejandbel Alejandbel commented May 22, 2024 •
edited
Loading

Closes #328

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I did not do unrelated and/or undiscussed refactorings

@Alejandbel Alejandbel force-pushed the ag-assign branch 2 times, most recently from d71776d to b784cf3 Compare May 22, 2024 22:05
Gusarich
Gusarich previously approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@Gusarich Gusarich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job! Also thanks for removing these whitespaces from grammar.ohm, they were pissing me off, haha 😆

@Gusarich Gusarich requested a review from anton-trunov May 23, 2024 06:47
@Gusarich Gusarich added this to the v1.4.0 milestone May 23, 2024
@byakuren-hijiri
Copy link
Contributor

byakuren-hijiri commented May 23, 2024 •
edited
Loading

We should consider modifying the type checker for this case, as these operations should be applied only to numeric types: #353.

@Gusarich
Copy link
Member

We should consider modifying the type checker for this case, as these operations should be applied only to numeric types: #353.

@Alejandbel you don't have to change anything in your PR for that, I've resolved this in #356

anton-trunov
anton-trunov requested changes May 24, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left some minor comments. Btw, we can only merge this PR after Tact v1.3.1 is released. In the mean we will inevitably introduce some merge conflicts.

CHANGELOG.md Outdated Show resolved Hide resolved
src/grammar/grammar.ohm Show resolved Hide resolved
src/grammar/grammar.ohm Outdated Show resolved Hide resolved
@anton-trunov
Copy link
Member

@Alejandbel Could you please update your PR after the grammar refactoring PR #365?

@Alejandbel
Copy link
Contributor Author

@Alejandbel Could you please update your PR after the grammar refactoring PR #365?

Yep, sure, will update it today

@Alejandbel
Copy link
Contributor Author

@Alejandbel Could you please update your PR after the grammar refactoring PR #365?

Updated

@Alejandbel Alejandbel requested a review from anton-trunov June 2, 2024 09:39
anton-trunov
anton-trunov previously approved these changes Jun 2, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks a lot!

@anton-trunov anton-trunov self-assigned this Jun 2, 2024
@anton-trunov
Copy link
Member

Hey @Alejandbel, your contribution qualifies for the Tact contributor SBT, would you mind sharing your TON wallet?

@Alejandbel
Copy link
Contributor Author

Sure, UQBSzBN6cnxDwDjn_IQXqgU8OJXUMcol9pxyL-yLkpKzYpKR

Hey @Alejandbel, your contribution qualifies for the Tact contributor SBT, would you mind sharing your TON wallet?

@anton-trunov
Copy link
Member

SBT sent!

@anton-trunov anton-trunov merged commit d46521d into tact-lang:main Jun 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

@Gusarich Gusarich Gusarich left review comments

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

Add support for |= &= and ^=
4 participants
@Alejandbel @byakuren-hijiri @Gusarich @anton-trunov