Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add test case covering recursive functions #359

Merged
merged 5 commits into from
May 27, 2024

Conversation

vitorpy
Copy link
Contributor

@vitorpy vitorpy commented May 24, 2024

Closes #303

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I did not do unrelated and/or undiscussed refactorings

@vitorpy vitorpy marked this pull request as ready for review May 26, 2024 10:08
Copy link
Member

@Gusarich Gusarich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's also add a recursive function outside of the contract (not a get-method) and call it in a separate function

Gusarich
Gusarich previously approved these changes May 27, 2024
Copy link
Member

@Gusarich Gusarich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, just a nitpick in the changelog

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@anton-trunov anton-trunov self-assigned this May 27, 2024
@anton-trunov anton-trunov merged commit 5a79bd8 into tact-lang:main May 27, 2024
3 checks passed
@vitorpy vitorpy deleted the add-recursive-fn-test-case branch May 27, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests with recursive functions
3 participants