Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for sst 14.1.0 #17

Open
wants to merge 7 commits into
base: devel
Choose a base branch
from
Open

Updates for sst 14.1.0 #17

wants to merge 7 commits into from

Conversation

kpgriesser
Copy link
Collaborator

@kpgriesser kpgriesser commented Oct 3, 2024

These edits are intended to merge after SST 14.1.0 is available.
This branch was tested using set-core version:
commit 7848d804fbdb0f936736f36b67f8f636547fd7f9 (HEAD -> master, origin/master, origin/HEAD) Merge: 0d412e16 1cc35cc8 Author: SST AutoTester <[email protected]> Date: Thu Oct 3 08:07:23 2024 -0600

Changes:

  • changed checkpoint restore tests to use new directory structure containing checkpoint files.
  • added wrapper script, sst-chkpt.sh, to remove previously generated checkpoint directory before running sst with checkpoint. This way the new checkpoint data always goes to the same directory.
  • added SCRIPT variable for CMakeLists.txt to refer to scripts directory.
  • Modified all test CMakeLists.txt files for tests that generate checkpoints to use the wrapper script to remove the checkpoint directory first.
  • changed sst-major-version.sh to allow for '-dev' versions of sst. These will always be assumed to be current. ( sst development versions do not appear to have numbering... just '-dev')
  • Fixed a typo in large-stat-chkpnt.cc preventing compilation.
  • commented out large-stat-chkpnt tests in test/CMakeLists.txt. These are timing out and filling the disk.

Kenneth Griesser added 4 commits August 2, 2024 14:18
@kpgriesser kpgriesser marked this pull request as draft October 3, 2024 21:24
@kpgriesser kpgriesser requested a review from jleidel October 3, 2024 21:24
@kpgriesser
Copy link
Collaborator Author

kpgriesser commented Oct 3, 2024

Only concerns are whether the large-stat tests were working with sst 14.0. Since the code didn't compile I assumed this was a work in progress. I only ran them with the latest master branch for sst-core.

Expecting sst-core to change again before it is released so no point in merging this to devel just yet.

@jleidel
Copy link
Contributor

jleidel commented Oct 3, 2024

  • large-stat-chkpnt

large-stat-chkpnt shouldn't compile until SST 14.1.0. This should be disabled by default until the build system detects 14.1.0+. large-stat should build and run fine.

Kenneth Griesser added 2 commits October 3, 2024 16:27
… in test area since 'git clean -f -d' can see the generated files to clean them out. The checkpoint files can be quite large
@kpgriesser
Copy link
Collaborator Author

kpgriesser commented Oct 19, 2024

I've put back in the large-stat* tests but there are timing out and generating some really large files.
Other than that, this PR is tested on MacOS and Ubuntu using the 14.1.0_beta branches for sst-core and sst-elements. Ready for your review for merging.

@kpgriesser kpgriesser marked this pull request as ready for review October 19, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants