remove obsolete input and pass-through of audience

[lusitania]

Description

Removes ineffective input tfc_aws_audience and replaces aws_iam_openid_connect_provider.this.client_id_list with the only value used globally: aws.workload.identity.

Related boilerplate resources random_string.sfx1 and random_string.sfx2 removed as well.

How Has This Been Tested?

1. terraform validate
2. Search over both orgs
   • org:urbanmedia audience
   • org:tagesspiegel audience

No functional use. Only IaC-terraform-cloud passes the output through which needs removal. This constitutes a breaking change.

Test Configuration:

• Terraform version: 1.9.2
• Module version:

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings

[leonsteinhaeuser]

Leave it configurable. If something changes in the future, this module would have to be patched. Instead, people could just change it themselves without waiting for us to patch this module.

[lusitania]

Leave it configurable. If something changes in the future, this module would have to be patched. Instead, people could just change it themselves without waiting for us to patch this module.

I strongly disagree. This is a prime example of boilerplate. "People" is "us". I am aware this module was made public, however the only commitment we have is to Tagesspiegel. If someone else finds this code useful they are not only free but encouraged to fork the project.

[leonsteinhaeuser]

Leave it configurable. If something changes in the future, this module would have to be patched. Instead, people could just change it themselves without waiting for us to patch this module.

I strongly disagree. This is a prime example of boilerplate. "People" is "us". I am aware this module was made public, however the only commitment we have is to Tagesspiegel. If someone else finds this code useful they are not only free but encouraged to fork the project.

This is not the way it works. This module is automatically pushed to the public Terraform registry and you are supposed to use it from there, not from GitHub. Forking is only intended if you want to introduce a change/fix. Why make it more complicated when it works and gives us and others more flexibility?

[lusitania]

Leave it configurable. If something changes in the future, this module would have to be patched. Instead, people could just change it themselves without waiting for us to patch this module.

I strongly disagree. This is a prime example of boilerplate. "People" is "us". I am aware this module was made public, however the only commitment we have is to Tagesspiegel. If someone else finds this code useful they are not only free but encouraged to fork the project.

This is not the way it works. This module is automatically pushed to the public Terraform registry and you are supposed to use it from there, not from GitHub. Forking is only intended if you want to introduce a change/fix. Why make it more complicated when it works and gives us and others more flexibility?

This is the way it works. Code is meant to serve a purpose. Boilerplate does not. Please check your lecture noted on Software Engineering. Can send you mine.

[lusitania]

I'll resolve this differently. This change is now obsolete.