refactor obsolete override tfc_hostname

[lusitania]

Description

Removes ineffective input tfc_hostname and materialises its value in

• module.aws_identity_provider.data.tls_certificate.tfc_certificate.url
• module.aws_tfc_dynamic_credentials_iam_roles.aws_iam_role.this.assume_role_policy

How Has This Been Tested?

1. terraform validate
2. Search over both orgs
   • org:urbanmedia audience
   • org:tagesspiegel audience

No functional use outside this module.

Test Configuration:

• Terraform version: 1.9.2
• Module version:

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings

[leonsteinhaeuser]

This is not a good idea because you can get your own instance of tfc where the hostname would change.

[lusitania]

This is not a good idea because you can get your own instance of tfc where the hostname would change.

Boilerplate argument. As of today we are not enacting such practice nor do we have any plans to do so.

[leonsteinhaeuser]

This is not a good idea because you can get your own instance of tfc where the hostname would change.

Boilerplate argument. As of today we are not enacting such practice nor do we have any plans to do so.

This is a public module. Do not assume that we are the only ones using it.

[lusitania]

This is not a good idea because you can get your own instance of tfc where the hostname would change.

Boilerplate argument. As of today we are not enacting such practice nor do we have any plans to do so.

This is a public module. Do not assume that we are the only ones using it.

Again, Tagesspiegel is not committed to serve the public in matters of code.

[lusitania]

I'll resolve this differently. This change is now obsolete.