Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust contract names after the Solidity code renames #395

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pdyraga
Copy link

@pdyraga pdyraga commented Oct 17, 2023

See: https://github.com/tahowallet/contracts/pull/415

The following changes have been applied on the contract side:

  • Creators Realm -> Galxe Realm
  • DeFi Realm -> Frax Realm
  • Educate Realm -> CyberConnect Realm
  • Social Realm -> Arbitrum Realm
  • Vampire Realm -> Gitcoin Realm

The new names reflect the names of partners for the Beta launch. In this PR, the changes are reflected on the dApp side.

The contract addresses in deployment-info.json will have to be adjusted once the contracts are redeployed on Arbitrum Sepolia.

The following changes have been applied on the contract side:

Creators Realm -> Galxe Realm
DeFi Realm -> Frax Realm
Educate Realm -> CyberConnect Realm
Social Realm -> Arbitrum Realm
Vampire Realm -> Gitcoin Realm

In this commit, the changes are reflected on the dApp side.

The contract addresses in `deployment-info.json` will have to be adjusted once
the contracts are redeployed on Arbitrum Sepolia.
@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for tally-ho-test-claim ready!

Name Link
🔨 Latest commit 00c83d3
🔍 Latest deploy log https://app.netlify.com/sites/tally-ho-test-claim/deploys/652e5f489ffe890008d6b301
😎 Deploy Preview https://deploy-preview-395--tally-ho-test-claim.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pdyraga pdyraga requested a review from jagodarybacka October 17, 2023 08:40
@pdyraga pdyraga marked this pull request as ready for review October 17, 2023 09:15
@jagodarybacka
Copy link
Contributor

Will add new addresses in this PR once they are known

@pdyraga pdyraga marked this pull request as draft October 18, 2023 10:19
@pdyraga
Copy link
Author

pdyraga commented Oct 18, 2023

We decided to abstract out the names. This will be done for mainnet launch. For beta launch, we'll stick to the existing names. Converting this PR to a draft for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants