Rework RPC caching #3771
Open
Rework RPC caching #3771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This streamlines RPC caching by consolidating balance and hasCode caches into a single unified map. Caching TTL can now be configured more flexibly per method inside `#cacheSettings`. The current caching mechanism does not prevent request duplication but that can be implemented afterwards
|
I think this one is relatively safe to merge, but the next set of changes will have to wait until e2e's are passing |
Shadowfiend
reviewed
Feb 13, 2025
| } | ||
|
|
||
| if (typeof val === "bigint") { | ||
| return `bigint:${val}` |
There was a problem hiding this comment.
Since we never deserialize, can this just be ${val}n?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This streamlines RPC caching by consolidating balance and hasCode caches into a single unified map. Caching TTL can now be configured more flexibly per method inside
#cacheSettings.The current caching mechanism does not prevent request duplication within batches but that can be implemented afterwards
To test