Reuse existing activity state data #3783
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a check into the account activity initialization process so we re-use already-enriched activity data if it corresponds to a finalized transaction. Improves worker startup and prevents requests bursts by optimizing activity initialization for tracked accounts.
Shadowfiend
reviewed
Feb 19, 2025
| transactions.forEach((transaction) => { | ||
| const { to, from, network } = transaction | ||
|
|
||
| const trackedAccounts = normalizedAccounts.filter( |
There was a problem hiding this comment.
For a self-send (where the same address is from and to), could this create a duplicate?
There was a problem hiding this comment.
Nope, because activities in this state tree are keyed by account address and the transaction's hash, so in cases where the from and to match the same tracked address the transaction is only added once as an activity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check into the account activity initialization process so we re-use already-enriched activity data if it corresponds to a finalized transaction.
Improves worker startup and prevents requests bursts by optimizing activity initialization for tracked accounts.
To Test
testertesting.ethLatest build: extension-builds-3783 (as of Mon, 17 Feb 2025 19:35:53 GMT).