Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[javascript] [misc] Remove redundant pybind include in Taichi Core Library (JS 7/n) #4110

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

AmesingFlank
Copy link
Collaborator

Related issue = #3781

@vercel
Copy link

vercel bot commented Jan 25, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/taichi-api-docs-preview/taichi/ASbrDwkoLtDry7rkgaRLEhDbGEc9
✅ Preview: Canceled

@netlify
Copy link

netlify bot commented Jan 25, 2022

✔️ Deploy Preview for docsite-preview canceled.

🔨 Explore the source changes: 79a9e46

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsite-preview/deploys/61ef4df075fb2b0008783914

@AmesingFlank AmesingFlank requested review from k-ye and ailzhang January 25, 2022 01:10
@AmesingFlank AmesingFlank changed the title [javascript] [python] Remove redundant pybind include in Taichi Core Library [javascript] [misc] Remove redundant pybind include in Taichi Core Library Jan 25, 2022
@AmesingFlank AmesingFlank changed the title [javascript] [misc] Remove redundant pybind include in Taichi Core Library [javascript] [misc] Remove redundant pybind include in Taichi Core Library (JS 7/n) Jan 25, 2022
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AmesingFlank AmesingFlank merged commit 9dc8ad3 into taichi-dev:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants