Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): replace image link and fix some usages of scripts #161

Closed
wants to merge 2 commits into from

Conversation

mask-pp
Copy link
Contributor

@mask-pp mask-pp commented Jan 9, 2024

docker-compose change, reference link:

  1. replace the image link from gcr.io/xxx to gcr.dockerproxy.com, so that users can pull images without a Google Cloud account.

shell script changes:

  1. In POSIX sh, [[ ]] is undefined.
  2. In POSIX sh, == in place of = is undefined.
  3. Use -n instead of ! -z.
  4. Double quote to prevent globbing and word splitting.

@mask-pp mask-pp changed the title replace image link and fix some usages of scripts feat(docker): replace image link and fix some usages of scripts Jan 10, 2024
@davidtaikocha
Copy link
Member

Could u rebase this PR on the katla branch?

@mask-pp mask-pp closed this Jan 11, 2024
@mask-pp mask-pp reopened this Jan 11, 2024
@mask-pp mask-pp closed this Jan 11, 2024
@mask-pp
Copy link
Contributor Author

mask-pp commented Jan 11, 2024

Could u rebase this PR on the katla branch?

Changed in a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants