chore(taiko-client): add more proof generation metrics (#18715)

taikoxyz · Jan 6, 2025 · ae07365 · ae07365
1 parent 6157af5
commit ae07365
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 2 deletions.
diff --git a/packages/taiko-client/internal/metrics/metrics.go b/packages/taiko-client/internal/metrics/metrics.go
@@ -55,21 +55,33 @@ var (
 	ProverAggregationSubmissionErrorCounter = factory.NewCounter(prometheus.CounterOpts{
 		Name: "prover_proof_aggregation_submission_error",
 	})
+	ProverAggregationGenerationTime = factory.NewGauge(prometheus.GaugeOpts{
+		Name: "prover_proof_aggregation_generation_time",
+	})
 	ProverSgxProofGeneratedCounter = factory.NewCounter(prometheus.CounterOpts{
 		Name: "prover_proof_sgx_generated",
 	})
+	ProverSgxProofGenerationTime = factory.NewGauge(prometheus.GaugeOpts{
+		Name: "prover_proof_sgx_generation_time",
+	})
 	ProverSgxProofAggregationGeneratedCounter = factory.NewCounter(prometheus.CounterOpts{
 		Name: "prover_proof_sgx_aggregation_generated",
 	})
 	ProverR0ProofGeneratedCounter = factory.NewCounter(prometheus.CounterOpts{
 		Name: "prover_proof_r0_generated",
 	})
+	ProverR0ProofGenerationTime = factory.NewGauge(prometheus.GaugeOpts{
+		Name: "prover_proof_r0_generation_time",
+	})
 	ProverR0ProofAggregationGeneratedCounter = factory.NewCounter(prometheus.CounterOpts{
 		Name: "prover_proof_r0_aggregation_generated",
 	})
 	ProverSp1ProofGeneratedCounter = factory.NewCounter(prometheus.CounterOpts{
 		Name: "prover_proof_sp1_generated",
 	})
+	ProverSP1ProofGenerationTime = factory.NewGauge(prometheus.GaugeOpts{
+		Name: "prover_proof_sp1_generation_time",
+	})
 	ProverSp1ProofAggregationGeneratedCounter = factory.NewCounter(prometheus.CounterOpts{
 		Name: "prover_proof_sp1_aggregation_generated",
 	})

diff --git a/packages/taiko-client/proposer/transaction_builder/fallback.go b/packages/taiko-client/proposer/transaction_builder/fallback.go
@@ -127,8 +127,15 @@ func (b *TxBuilderWithFallback) BuildOntake(
 		return b.blobTransactionBuilder.BuildOntake(ctx, txListBytesArray)
 	}
 
-	metrics.ProposerEstimatedCostCalldata.Set(float64(costCalldata.Uint64()))
-	metrics.ProposerEstimatedCostBlob.Set(float64(costBlob.Uint64()))
+	var (
+		costCalldataFloat64 float64
+		costBlobFloat64     float64
+	)
+	costCalldataFloat64, _ = utils.WeiToEther(costCalldata).Float64()
+	costBlobFloat64, _ = utils.WeiToEther(costBlob).Float64()
+
+	metrics.ProposerEstimatedCostCalldata.Set(costCalldataFloat64)
+	metrics.ProposerEstimatedCostBlob.Set(costBlobFloat64)
 
 	if costCalldata.Cmp(costBlob) < 0 {
 		log.Info("Building a type-2 transaction", "costCalldata", costCalldata, "costBlob", costBlob)

diff --git a/packages/taiko-client/prover/proof_producer/sgx_producer.go b/packages/taiko-client/prover/proof_producer/sgx_producer.go
@@ -333,6 +333,7 @@ func (s *SGXProofProducer) requestBatchProof(
 		"time", time.Since(requestAt),
 		"producer", "SGXProofProducer",
 	)
+	metrics.ProverAggregationGenerationTime.Set(float64(time.Since(requestAt).Seconds()))
 
 	return proof, nil
 }
@@ -390,6 +391,7 @@ func (s *SGXProofProducer) callProverDaemon(
 		"time", time.Since(requestAt),
 		"producer", "SGXProofProducer",
 	)
+	metrics.ProverSgxProofGenerationTime.Set(float64(time.Since(requestAt).Seconds()))
 
 	return proof, nil
 }

diff --git a/packages/taiko-client/prover/proof_producer/zkvm_producer.go b/packages/taiko-client/prover/proof_producer/zkvm_producer.go
@@ -196,6 +196,11 @@ func (s *ZKvmProofProducer) callProverDaemon(
 		"time", time.Since(requestAt),
 		"producer", "ZKvmProofProducer",
 	)
+	if s.ZKProofType == ZKProofTypeR0 {
+		metrics.ProverR0ProofGenerationTime.Set(float64(time.Since(requestAt).Seconds()))
+	} else if s.ZKProofType == ZKProofTypeSP1 {
+		metrics.ProverSP1ProofGenerationTime.Set(float64(time.Since(requestAt).Seconds()))
+	}
 
 	return proof, nil
 }