Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol): update DeployOnL1 script based on Ownable2StepUpgradeable changes #16062

Closed
wants to merge 8 commits into from
Closed

feat(protocol): update DeployOnL1 script based on Ownable2StepUpgradeable changes #16062

wants to merge 8 commits into from

Conversation

davidtaikocha
Copy link
Member

No description provided.

dantaik
dantaik reviewed Feb 25, 2024
View reviewed changes
packages/protocol/contracts/libs/LibDeploy.sol Outdated
}
}

function acceptProxyOwnershipByTimelock(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

acceptOwnership

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

@dantaik dantaik self-requested a review February 25, 2024 13:24
@dantaik dantaik enabled auto-merge February 25, 2024 13:32
@dantaik dantaik requested a review from Brechtpd February 25, 2024 13:32
@davidtaikocha davidtaikocha marked this pull request as draft February 25, 2024 15:07
@dantaik dantaik changed the base branch from main to improve_essential_contract February 25, 2024 22:32
@dantaik
Copy link
Contributor

dantaik commented Feb 26, 2024

#16071 should work

@dantaik dantaik closed this Feb 26, 2024
@dantaik dantaik deleted the update-Ownable2StepUpgradeable branch March 1, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantaik dantaik dantaik approved these changes

@adaki2004 adaki2004 adaki2004 approved these changes

@Brechtpd Brechtpd Brechtpd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidtaikocha @dantaik @Brechtpd @adaki2004