Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(taiko-client): impossible false value return #18736

Closed
wants to merge 2 commits into from
Closed

fix(taiko-client): impossible false value return #18736

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e91ff74
impossible false value return
mask-pp Jan 9, 2025
f3b6dc2
Merge branch 'main' into fix_driver_p2p_sync_2
mask-pp Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions packages/taiko-client/driver/chain_syncer/chain_syncer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,12 +159,6 @@ func (s *L2ChainSyncer) AheadOfHeadToSync(heightToSync uint64) bool {
return false
}

// If the L2 execution engine's chain is ahead of the block head to sync,
// we can mark the beacon sync progress as finished.
if s.progressTracker.LastSyncedBlockID() != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its still needed, to mark the end of the current beacon sync?

return s.state.GetL2Head().Number.Uint64() >= s.progressTracker.LastSyncedBlockID().Uint64()
}

return true
}

Expand Down
Loading