-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chores: Edition 2018, quick-error -> thiserror, deps update #15
base: master
Are you sure you want to change the base?
Conversation
Required by error frameworks such as `thiserror`, `anyhow`, and `eyre`.
Hey @tailhook, is there anything left to do here? |
☃️ it'd be awesome if I could get some feedback on this 🙂 |
Yes, sorry. This has so much stuff, I don't have enough time to review. I'm also not sure if I agree with thiserror and fs_err. This crate has their own errors to have both, nice error messages or performance on failure path if needed. But I still need to look at details, which I had no time to do yet. Hopefully, I'll find some time to take a look soon. |
The rest is mostly chore. The thing that is breaking, are the additional bounds on |
Anything I can add or do here? |
A bunch of chores, should be fairly well separated into individual commits.