renamed: DangerCommentable to ViolationNotifier

taji-taji · Aug 28, 2022 · c7c9932 · c7c9932
1 parent 35c2a9d
commit c7c9932
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/Sources/DangerSwiftPeriphery/DangerDSL+Extensions.swift b/Sources/DangerSwiftPeriphery/DangerDSL+Extensions.swift
@@ -1,6 +1,6 @@
 import Danger
 
-extension DangerDSL: DangerCommentable {
+extension DangerDSL: ViolationNotifier {
     func warn(violation: Violation) {
         warn(message: violation.message,
              file: violation.filePath,

diff --git a/Sources/DangerSwiftPeriphery/DangerPeriphery.swift b/Sources/DangerSwiftPeriphery/DangerPeriphery.swift
@@ -89,9 +89,9 @@ public enum DangerPeriphery {
         }
     }
 
-    static func handleScanResult<DC: DangerCommentable>(_ scanResult: Result<[Violation], Error>,
-                                                        danger: DC,
-                                                        shouldComment: Bool) {
+    static func handleScanResult<Notifier: ViolationNotifier>(_ scanResult: Result<[Violation], Error>,
+                                                              danger: Notifier,
+                                                              shouldComment: Bool) {
         guard shouldComment else { return }
         switch scanResult {
         case .success(let violations):

diff --git a/...gerSwiftPeriphery/DangerCommentable.swift → ...gerSwiftPeriphery/ViolationNotifier.swift b/...gerSwiftPeriphery/DangerCommentable.swift → ...gerSwiftPeriphery/ViolationNotifier.swift
@@ -1,6 +1,6 @@
 import Foundation
 
-protocol DangerCommentable {
+protocol ViolationNotifier {
     func warn(violation: Violation)
     func fail(_ message: String)
 }
diff --git a/Tests/DangerSwiftPeripheryTests/DangerSwiftPeripheryTests.swift b/Tests/DangerSwiftPeripheryTests/DangerSwiftPeripheryTests.swift
@@ -6,15 +6,15 @@ final class DangerSwiftPeripheryTests: XCTestCase {
     private var scanExecutor: PeripheryScanExecutableMock!
     private var outputParser: CheckstyleOutputParsableMock!
     private var diffProvider: PullRequestDiffProvidableMock!
-    private var dangerCommentable: DangerCommentableMock!
+    private var dangerCommentable: ViolationNotifierMock!
 
     override func setUp() {
         super.setUp()
 
         scanExecutor = PeripheryScanExecutableMock()
         outputParser = CheckstyleOutputParsableMock()
         diffProvider = PullRequestDiffProvidableMock()
-        dangerCommentable = DangerCommentableMock()
+        dangerCommentable = ViolationNotifierMock()
     }
 
     func testScanErrorOccurredWhileScanning() throws {

diff --git a/...ryTests/Mocks/DangerCommentableMock.swift → ...ryTests/Mocks/ViolationNotifierMock.swift b/...ryTests/Mocks/DangerCommentableMock.swift → ...ryTests/Mocks/ViolationNotifierMock.swift
@@ -5,7 +5,7 @@
 import Foundation
 @testable import DangerSwiftPeriphery
 
-final class DangerCommentableMock: DangerCommentable {
+final class ViolationNotifierMock: ViolationNotifier {
     var warnHandler: ((Violation) -> Void)?
     var failHandler: ((String) -> Void)?
     private(set) var warnCallCount = 0