Parallel Tests: #66

[MaxMaeder]

Rewrote Accept to send assigned port to portChan, a member of MockServer, also modified tests in stream_test.go to make use of this so that they can be run in parallel.

[sergiu128]

Hey, thank you! Sorry for the late reply, had very busy days at work.

I think this looks good, but maybe we can make it shorter? Some suggestions:

• I think we can get rid of wsURI in most places:

ws.AsyncHandshake(fmt.Sprintf("ws://localhost:%d", <-portChan), ...)

• I think the mock server can just own the port channel

srv := NewMockServer()
go func() { srv.Accept(...) }
ws.AsyncHandshake(fmt.Sprintf("ws:/localhost:%d", <-srv.portChan), ...

• With the above changes, the server then owns the port assignment. Can get rid of GetFreePort and just have the server listener bind to "localhost:0" if addr == "". Something similar to this:

const MockServerRandomAddr = "" // or some better name
func (s *MockServer) Accept(addr string) (err error) {
         if addr == MockServerRandomAddr {
	    s.ln, err = net.Listen("tcp", "localhost:0")
	 } else {
	     s.ln, err = net.Listen("tcp", addr)
	 }
	 if err != nil { return err }
	 s.portChan <- ln.Addr().(*net.TCPAddr).Port

This will make for less code in the tests and less setup in each instance. After you do this part, I'll take the rest of the tests.

[sergiu128]

If you're still interested, here are some more exciting problems to solve in no particular order:

• Don't heap-alloc on each read/write in async_adapter. #146 - short, provides exposure to how async reads/writes work
• Support multishot reads/writes #119 - short/medium, provides exposure to how we use the OS' poller (epoll and kqueue) and how events are dispatched
• Implement AsyncDial #147 - short/medium, provides exposure to using the poller in new scenarios. Might need some code restructuring.
• Prevent copying on each read in websocket #150 - medium, provides exposure to how the websocket codec works

Ping me if you're up for any of these!

[MaxMaeder]

Thanks for the feedback, the way you're suggesting makes a lot more sense!

I refactored the MockServer and the tests, let me know what you think.

[sergiu128]

Awesome work, thank you!