Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update rewards payout formula #887

Closed
wants to merge 29 commits into from
Closed

fix: update rewards payout formula #887

wants to merge 29 commits into from

Conversation

1xstj
Copy link
Contributor

@1xstj 1xstj commented Jan 20, 2025 •
edited
Loading

Summary of changes
Changes introduced in this pull request:

  • Fix reward calculation formula
  • Update and add tests

@1xstj 1xstj changed the title bug: fix rewards formula fix: update rewards payout formula Jan 20, 2025
@1xstj 1xstj marked this pull request as ready for review January 20, 2025 19:37
drewstone
drewstone requested changes Jan 21, 2025
View reviewed changes
pallets/rewards/src/tests/claim.rs Outdated Show resolved Hide resolved
pallets/rewards/src/functions.rs Outdated Show resolved Hide resolved
@1xstj 1xstj requested a review from drewstone January 23, 2025 07:45
@drewstone
Copy link
Contributor

E2E tests failing

shekohex
shekohex approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@shekohex shekohex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is good, just need to update subxt too! then we can publish a new version.

@1xstj 1xstj mentioned this pull request Jan 27, 2025
Merged
@1xstj 1xstj closed this Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekohex shekohex shekohex approved these changes

@drewstone drewstone Awaiting requested review from drewstone drewstone is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@1xstj @drewstone @shekohex