-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duration issue research #155
base: master
Are you sure you want to change the base?
Conversation
what's your theory behind why the duration was off? When I try to follow your edits it seems logically the same as what it was before in terms of how predicted duration and duration is updated |
@newbdez33 Is this an attempt to solve the problem where you scrub into a file that's streaming (downloaded doesn't appear to have this problem) and it results in the needle exceeding the duration at the end of the file? I was about to dig into that problem, but if you're attempting to address it here, I'll dig into your code instead. |
Sorry for late reply. I don't have time to solve this problem so far. |
Changes from PR tanhakabir#155 tanhakabir/SwiftAudioPlayer@master...HKdAlex:SwiftAudioPlayer:master Also update lines 123-128 of AudioStreamEngine to avoid duration being overridden by predictedStreamDuration once stream has completed
@newbdez33 , thanks a million for your work on this. I made a fork that incorporates your changes. Additionally, I had to tweak the Anyway, just figured I'd post the commit in case any others are running into this. I'll plan on maintaining this fork until some of these PR's are merged. |
Changes from PR tanhakabir#155 tanhakabir/SwiftAudioPlayer@master...HKdAlex:SwiftAudioPlayer:master Also update lines 123-128 of AudioStreamEngine to avoid duration being overridden by predictedStreamDuration once stream has completed
Just a theory.