feat(SAPlayer) avoid shared instance #172
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is addressing the following:
Basically I've removed the shared instance and made the
SAPlayer
public. This allows whoever uses the library to play simultaneously more than one audio file. The caveat is that theAVAudioEngine
must be created outside of the library.I've played around with the demo, and everything seems to keep working as before.
I'm sorry for the big diff, I launched a
swiftformat
inside the project.Only question, I commented the
pause
on thenumberOfBuffersScheduledInTotal#didSet
Nothing seems to change. What was that
pause()
guarding?