Implement support for Closures. #26
Conversation
| val typ = TypeTransformer.transformType(param.ptpe) | ||
| WasmLocal(WasmLocalName.fromIR(param.name.name), typ, isParameter = true) | ||
| } | ||
| val resultTyps = TypeTransformer.transformResultType(IRTypes.AnyType) |
There was a problem hiding this comment.
Can't we use tree.body.tpe ?
| val resultTyps = TypeTransformer.transformResultType(IRTypes.AnyType) | |
| val resultTyps = TypeTransformer.transformResultType(tree.body.tpe) |
There was a problem hiding this comment.
Because the declared result type is implicitly always any. If the body happens to be a primitive int, we need to box it to match the declared result type. I expanded a little bit on the comment on generateIRBody.
| closureRest: (f, data, n) => ((...args) => f(data, ...args.slice(0, n), args.slice(n))), | ||
| closureThisRest: (f, data, n) => function(...args) { return f(this, data, ...args.slice(0, n), args.slice(n)); }, |
There was a problem hiding this comment.
It seems that the imported function for closureRest and closureThisRest receive two args (f and data) but doesn't have third argument (n). Where this arg comes from?
(import "__scalaJSHelpers" "closureRest" (func $__scalaJSHelpers#closureRest___fun (param (ref func)) (param anyref) (result (ref any))))
(import "__scalaJSHelpers" "closureThisRest" (func $__scalaJSHelpers#closureThisRest___fun (param (ref func)) (param anyref) (result (ref any))))Also, how can we test these? it seems the test cases doesn't have a restParameter.
There was a problem hiding this comment.
Oops, good catch! I fixed it in the expression builder.
Also, how can we test these? it seems the test cases doesn't have a
restParameter.
As the comment in the tests mentions, currently we cannot test the ...rest parameters. Although the IR does not require it, the source syntax that creates Closures with rest params also requires Scala's full-blown Seqs (for vararags). We'll be able to add tests when we have enough things to support Seq.
| /* If there is a ...rest param, the helper requires as third argument the | ||
| * number of regular arguments. | ||
| */ | ||
| if (hasRestParam) | ||
| instrs += I32_CONST(I32(tree.params.size)) |
Based on #21.