Support of .jsonl files implemented
#816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mulla028
changed the title
.jsonl files implemented
Deploying chatcraft-org with
|
| Latest commit: |
8262152
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://33f4f280.console-overthinker-dev.pages.dev |
| Branch Preview URL: | https://mulla028-jsonl-file-support.console-overthinker-dev.pages.dev |
humphd
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Looks good. Interesting that we already have it here:
export const acceptableFileFormats =
"image/*,text/*,.pdf,application/pdf,*.docx,application/vnd.openxmlformats-officedocument.wordprocessingml.document,.json,application/json,.jsonl,application/x-jsonlines,application/jsonl,application/markdown";
I added it in #804 as a last commit, but it didn't work |
|
May I land this? |
|
When CI is green, and you have a reviewer saying it's good, you can land without more permissions. Go for it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #810
Description
In #804 @tarasglek found out that we don't have a support of
.jsonlfiles attachments, and we obviously needed to do something with it! I decided to step up and provide a support of.jsonlfiles, and I have no clue what else to write here because it is a tiny change, but description required :DResult