Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to work around issues causing failing tests. #1

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

jacksonrayhamilton
Copy link

Hi, I'd like to help get jfirebaugh#233 merged.

Locally I've been able to get the tests to pass with the changes in 342eece. I am pretty sure that my solution is not "correct," but maybe it will be able to inspire someone with more Rails experience as to what should actually be done to solve the failing tests.

tarebyte and others added 10 commits November 13, 2016 17:35
I have a strong feeling that there is a better way of doing this.  It seems like
paths for JavaScript and CoffeeScript files within the "Dummy" application's
root are not searched, although I would have expected them to be.  It seems as
if konacha's asset directories are searched instead.  Also, Rails won't load
jQuery using Sprockets for reason.  (Maybe because the application is in a
subdirectory it doesn't know about the jquery-rails gem?)
@jacksonrayhamilton
Copy link
Author

Darn. I am hitting a wall on the errors in the other Gemfiles in the build matrix. Maybe you will have a better idea of what is wrong and how to solve these issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants