fix panic when empty stack trace (#1)

taxio · Jan 8, 2024 · caa564a · caa564a
1 parent f2efcff
commit caa564a
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/error.go b/error.go
@@ -33,6 +33,9 @@ func (e *Error) Unwrap() error {
 }
 
 func (e *Error) StackTrace() []uintptr {
+	if e.stack == nil {
+		return nil
+	}
 	return *e.stack
 }
 

diff --git a/errors_test.go b/errors_test.go
@@ -129,6 +129,18 @@ func TestWithStack(t *testing.T) {
 			}
 		}
 	})
+
+	t.Run("empty", func(t *testing.T) {
+		baseErr := stderr.New("base")
+		err := errors.Wrap(baseErr)
+		var cErr *errors.Error
+		if ok := errors.As(err, &cErr); !ok {
+			t.Fatal("expected error to be *errors.Error")
+		}
+		if len(cErr.StackTrace()) != 0 {
+			t.Errorf("expected no stack trace")
+		}
+	})
 }
 
 func TestWithAttrs(t *testing.T) {