Skip to content

Commit

Permalink
add baseline with inline assets & fix issues (#584)
Browse files Browse the repository at this point in the history
* add baseline with inline assets

* suppress warning for invalid css

* include img directory in package
  • Loading branch information
bakkot authored Mar 22, 2024
1 parent 5f8b4d5 commit 7354849
Show file tree
Hide file tree
Showing 5 changed files with 3,262 additions and 1 deletion.
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
"/lib",
"/js",
"/css",
"/img",
"/fonts",
"/boilerplate",
"/entities-processed.json"
Expand Down
1 change: 1 addition & 0 deletions src/Spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1030,6 +1030,7 @@ ${await utils.readFile(path.join(__dirname, '../js/multipage.js'))}

private async buildAssets(jsContents: string, jsSha: string) {
if (this.assets.type === 'none') return;
this.log('Building assets...');

// check for very old manual 'ecmarkup.js'/'ecmarkup.css'
const oldEles = this.doc.querySelectorAll(
Expand Down
6 changes: 5 additions & 1 deletion src/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,11 @@ export function emdTextNode(spec: Spec, node: Text, namespace: string) {

/*@internal*/
export function htmlToDom(html: string) {
return new jsdom.JSDOM(html, { includeNodeLocations: true });
const virtualConsole = new jsdom.VirtualConsole();
virtualConsole.on('error', () => {
// Suppress warnings from e.g. CSS features not supported by JSDOM
});
return new jsdom.JSDOM(html, { includeNodeLocations: true, virtualConsole });
}

/*@internal*/
Expand Down
Loading

0 comments on commit 7354849

Please sign in to comment.