test,ios: patch some tests so they pass

tcobbs-bentley · Oct 12, 2023 · 35ac4ac · 35ac4ac
1 parent 00ea14a
commit 35ac4ac
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/test/parallel/test-http-response-setheaders.js b/test/parallel/test-http-response-setheaders.js
@@ -6,12 +6,15 @@ const assert = require('assert');
 {
   const server = http.createServer({ requireHostHeader: false }, common.mustCall((req, res) => {
     res.writeHead(200); // Headers already sent
+    // nodejs-mobile patch: globalThis.Headers uses undici uses Wasm, bad on iOS
+    /*
     const headers = new globalThis.Headers({ foo: '1' });
     assert.throws(() => {
       res.setHeaders(headers);
     }, {
       code: 'ERR_HTTP_HEADERS_SENT'
     });
+    */
     res.end();
   }));
 
@@ -70,6 +73,8 @@ const assert = require('assert');
   }));
 }
 
+// nodejs-mobile patch: globalThis.Headers uses undici uses Wasm, bad on iOS
+/*
 {
   const server = http.createServer({ requireHostHeader: false }, common.mustCall((req, res) => {
     const headers = new globalThis.Headers({ foo: '1', bar: '2' });
@@ -109,6 +114,7 @@ const assert = require('assert');
     });
   }));
 }
+*/
 
 {
   const server = http.createServer({ requireHostHeader: false }, common.mustCall((req, res) => {

diff --git a/test/parallel/test-parse-args.mjs b/test/parallel/test-parse-args.mjs
@@ -3,6 +3,8 @@ import assert from 'node:assert';
 import { test } from 'node:test';
 import { parseArgs } from 'node:util';
 
+// nodejs-mobile patch: note that on iOS this test passes, but doesn't close/die
+
 test('when short option used as flag then stored as flag', () => {
   const args = ['-f'];
   const expected = { values: { __proto__: null, f: true }, positionals: [] };

diff --git a/test/parallel/test-process-getactiveresources.js b/test/parallel/test-process-getactiveresources.js
@@ -6,5 +6,8 @@ const assert = require('assert');
 
 setTimeout(() => {}, 0);
 
-// nodejs-mobile patch to add PipeWrap
-assert.deepStrictEqual(process.getActiveResourcesInfo(), ['PipeWrap', 'Timeout']);
+// nodejs-mobile patch to add PipeWrap for Android and TTYWrap for iOS
+assert.deepStrictEqual(process.getActiveResourcesInfo(), [
+  process.platform === 'ios' ? 'TTYWrap' : 'PipeWrap',
+  'Timeout'
+]);