Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set source encoding for template files #804

Merged

Conversation

alerosmile
Copy link
Contributor

Closes #793

@alerosmile alerosmile marked this pull request as ready for review January 10, 2025 14:20
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.19%. Comparing base (92fee05) to head (df87db8).
Report is 158 commits behind head on master.

Files with missing lines Patch % Lines
src/main/java/org/vafer/jdeb/DebMaker.java 75.00% 2 Missing and 1 partial ⚠️
src/main/java/org/vafer/jdeb/ControlBuilder.java 80.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #804      +/-   ##
============================================
+ Coverage     71.03%   74.19%   +3.15%     
- Complexity       96      118      +22     
============================================
  Files             7        8       +1     
  Lines           580      620      +40     
  Branches         75       81       +6     
============================================
+ Hits            412      460      +48     
+ Misses          121      107      -14     
- Partials         47       53       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alerosmile alerosmile marked this pull request as draft January 10, 2025 17:55
@alerosmile alerosmile force-pushed the set-source-encoding-for-template-files branch from ce82c5e to df87db8 Compare January 10, 2025 18:56
@alerosmile alerosmile marked this pull request as ready for review January 10, 2025 19:01
@tcurdt tcurdt merged commit 2ccc1b8 into tcurdt:master Jan 11, 2025
7 checks passed
@tcurdt
Copy link
Owner

tcurdt commented Jan 11, 2025

Looking good thanks!

@alerosmile alerosmile deleted the set-source-encoding-for-template-files branch January 11, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FilteredFile does not support UTF8 files
3 participants