Skip to content

Commit

Permalink
fix(terminal-char): unwanted terminal characters being written to the…
Browse files Browse the repository at this point in the history
… terminal
  • Loading branch information
231tr0n committed Mar 4, 2024
1 parent 47e0983 commit 12ec289
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 6 deletions.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,16 +42,16 @@ npm run test
npm run commitlint
```

### Important points to note when contributing.
## Important points to note when contributing.

- Running the below command can be useful for easily creating commit messages following conventional commiting format.
- `npm run commit`
- Running the below command can be useful if the github action fails to find out what is the error.
- `npm run ci`
- Github action will fail in the following scenarios
1. Eslint linting error
2. Prettier formatting error
3. Build error
4. Test error
5. Commit message not following [conventional commiting format](https://conventionalcommits.org)
- In the event of failure of the github action, go to its logs and check which job has failed and what is the error printed so that it can be debugged and resolved.
- Running the below command can be useful if the github action fails.
- `npm run ci`
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"svelte-check": "^3.6.6",
"tslib": "^2.6.2",
"typescript": "^5.3.3",
"unlighthouse": "^0.11.3",
"unlighthouse": "^0.11.4",
"vite": "^5.1.4",
"vitest": "^1.3.1"
},
Expand Down
6 changes: 4 additions & 2 deletions src/lib/components/Terminal.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -347,8 +347,10 @@
term.write('\b \b');
}
} else {
typedPrompt += e;
term.write(e);
if (e.charCodeAt(0) > 31 && e.charCodeAt(0) < 127) {
typedPrompt += e;
term.write(e);
}
}
});
Expand Down

0 comments on commit 12ec289

Please sign in to comment.