Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update webhooks guide, include new username events #116

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lfleischmann
Copy link
Member

@lfleischmann lfleischmann commented Jan 20, 2025

Comment on lines +47 to +49
<ResponseField name="username" type="object">
The username of the user
</ResponseField>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

username is an object but does not specify the object structure itself, like e.g. webauthn_credentials

</ResponseField>
</Expandable>
</ResponseField>
<ResponseField name="evt" type="boolean">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<ResponseField name="evt" type="boolean">
<ResponseField name="evt" type="string">

</ResponseField>
</Expandable>
</ResponseField>
<ResponseField name="evt" type="boolean">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<ResponseField name="evt" type="boolean">
<ResponseField name="evt" type="string">

tampered with.
</ResponseField>

<ResponseField name="event" type="boolean">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<ResponseField name="event" type="boolean">
<ResponseField name="event" type="string">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants