Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set fluentd thread count by env variable #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pdomagala
Copy link

No description provided.

@pdomagala
Copy link
Author

Oh, I noticed that I also changed log_level to warn, but IMO it also should be changeable via an environment variable, because in my case it flooded us with logs. I'll change it later.

@Cryptophobia Cryptophobia self-requested a review March 12, 2021 17:32
@Cryptophobia
Copy link
Member

Hey @pdomagala , thank you for the contribution. This addition will be nice! Can you format the commit msg using the PR commit message format: https://docs.teamhephy.com/contributing/submitting-a-pull-request/

Something like feat(fluentd): enable set flush and threads via ENV vars will be sufficient

Also, is there a way we can make the log_level configurable via the helm chart values?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants