Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team Hephy #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Team Hephy #3

wants to merge 1 commit into from

Conversation

kingdonb
Copy link
Member

If we should need to change the s3-uploader in the near future, to go with #2 then the changes will go in this PR.

(I also upgraded golang from 1.6 to 1.11)

set s/deis/teamhephy/ and refresh minio version upstream
@kingdonb kingdonb force-pushed the teamhephy branch 2 times, most recently from 3db848b to 4af816b Compare October 29, 2018 02:23
@kingdonb
Copy link
Member Author

This should be ready to merge

make bootstrap && make build

(Will work once this gets merged, what we have in the master branch right now is broken)

This works, I merged a similar PR in kingdonb/s3-uploader master branch for testing in kingdonb#3

@kingdonb
Copy link
Member Author

You may hold off on merging this until after v2.20 (would you give me access to labels/milestones please so I can notate this for the roadmap in advance of the Open Roadmap meeting this week?)

I have only tested that the build succeeds, I don't know if upgrading to minio 6.0.9 causes any other harm, but only this package is upgraded here, so far at least.

(Or, we could just test it all before the release)

@kingdonb
Copy link
Member Author

Noting that there are related changes in teamhephy/distribution#1, teamhephy/workflow#71, teamhephy/object-storage-cli#1, teamhephy/distribution#2, ... ensure that we can use the "endpoint" value configured by those when they merge, from this utility here too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant