feat: set oneOf json schema property for id and string messages #1326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ID and String messages, we want to set the json schema to use
oneOf
so that only one of the filters can be used at a time. Tom and I had a chat about this and agreed that we would only do this for ID and String fields for now and only allowing one filter at a time makes sense for both string and id filters.Looking for feedback on how best to approach this
Attempting to go from:
to: