-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add built-in duration type #1701
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc82a57
to
96a5bf5
Compare
davenewza
reviewed
Jan 21, 2025
davenewza
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Duration type is a first-class Keel model type and will capture an interval of time. For example:
The duration field will accept ISO 8601 durations, e.g.
P1Y10M4DT10H2M1S
. These data types will be stored in the DB as Postgres'Interval
types.When generating the JSON schema for the Keel app's API, these fields will be of type:
string
and formatduration
.Filter support
When a
Duration
field is defined as a filterable field for a list action, the input message will support the following fields/operations:The resolution of these operations will be deferred to the DB engine.
ModelAPI & Functions Runtime support
We're introducing a new class in the keel functions runtime sdk:
Duration
and built-in support in the modelAPI.Considering the following keel model schema:
We are able to interact with the
dur
field through thesdk.Duration
class: