Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgraded kysely #1719

Merged
merged 3 commits into from
Feb 21, 2025
Merged

feat: upgraded kysely #1719

merged 3 commits into from
Feb 21, 2025

Conversation

davenewza
Copy link
Contributor

Upgraded Kysely and deprecated orWhere in the ModelAPI

Kysely updated to 0.27.5, which included some breaking changes to their API. This unlocks Kysely's expression builder updates.

We have also deprecated the orWhere function on the ModelAPI.

@jonbretman
Copy link
Member

@davenewza what's happening with this PR? I'm assuming we don't want to drop the orderBy and limit functions from the query builder?

@davenewza
Copy link
Contributor Author

@davenewza what's happening with this PR? I'm assuming we don't want to drop the orderBy and limit functions from the query builder?

@jonbretman They have been commented out for an age and I dont know why. I'll try look into it today

@davenewza davenewza merged commit b237315 into main Feb 21, 2025
10 checks passed
@davenewza davenewza deleted the feat/kysely-upgrade-orwhere-dep branch February 21, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants