[FIX/#267] git pull from develop

teamterning · Sep 27, 2024 · da06b7e · da06b7e
2 parents 7dfb8e4 + 436c3d2
commit da06b7e
Show file tree

Hide file tree

Showing 11 changed files with 16 additions and 66 deletions.
diff --git a/core/src/main/assets/terning_scrap_cancel.json b/core/src/main/assets/terning_scrap_cancel.json
diff --git a/core/src/main/assets/terning_start_home.json b/core/src/main/assets/terning_start_home.json
diff --git a/feature/src/main/assets/terning_scrap_cancel.json b/feature/src/main/assets/terning_scrap_cancel.json
diff --git a/feature/src/main/java/com/terning/feature/calendar/list/CalendarListScreen.kt b/feature/src/main/java/com/terning/feature/calendar/list/CalendarListScreen.kt
@@ -44,6 +44,7 @@ import com.terning.feature.calendar.list.component.CalendarScrapList
 import com.terning.feature.calendar.list.model.CalendarListUiState
 import com.terning.feature.dialog.cancel.ScrapCancelDialog
 import com.terning.feature.dialog.detail.ScrapDialog
+import okhttp3.internal.toImmutableList
 import java.time.LocalDate
 
 @Composable
@@ -175,8 +176,7 @@ private fun CalendarListScreen(
                             )
 
                             CalendarScrapList(
-                                selectedDate = currentDate,
-                                scrapList = scrapMap[dateInKorean].orEmpty(),
+                                scrapList = scrapMap[dateInKorean].orEmpty().toImmutableList(),
                                 onScrapButtonClicked = onClickScrapButton,
                                 onInternshipClicked = onClickInternship,
                                 isFromList = true,

diff --git a/feature/src/main/java/com/terning/feature/calendar/list/component/CalendarScrap.kt b/feature/src/main/java/com/terning/feature/calendar/list/component/CalendarScrap.kt
@@ -6,6 +6,8 @@ import androidx.compose.ui.graphics.Color
 import androidx.compose.ui.unit.dp
 import com.terning.core.designsystem.component.item.InternItem
 import com.terning.core.designsystem.component.item.ScrapBox
+import com.terning.core.designsystem.theme.Grey200
+import com.terning.core.extension.customShadow
 import com.terning.core.extension.noRippleClickable
 import com.terning.domain.entity.calendar.CalendarScrapDetail
 
@@ -17,12 +19,15 @@ fun CalendarScrap(
     modifier: Modifier = Modifier,
 ) {
     ScrapBox(
-        modifier = modifier.noRippleClickable {
+        modifier = modifier.customShadow(
+            color = Grey200,
+            shadowRadius = 5.dp,
+            shadowWidth = 1.dp,
+        ).noRippleClickable {
             onInternshipClicked(scrap)
         },
         cornerRadius = 10.dp,
-        scrapColor = Color(android.graphics.Color.parseColor(scrap.color)),
-        elevation = 1.dp,
+        scrapColor = Color(android.graphics.Color.parseColor(scrap.color))
     ) {
         InternItem(
             scrapId = scrap.internshipAnnouncementId,

diff --git a/feature/src/main/java/com/terning/feature/calendar/list/component/CalendarScrapList.kt b/feature/src/main/java/com/terning/feature/calendar/list/component/CalendarScrapList.kt
@@ -3,17 +3,16 @@ package com.terning.feature.calendar.list.component
 import androidx.compose.foundation.layout.Column
 import androidx.compose.foundation.layout.Spacer
 import androidx.compose.foundation.layout.height
+import androidx.compose.foundation.layout.padding
 import androidx.compose.foundation.rememberScrollState
 import androidx.compose.foundation.verticalScroll
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.unit.dp
 import com.terning.domain.entity.calendar.CalendarScrapDetail
-import java.time.LocalDate
 
 @Composable
 internal fun CalendarScrapList(
-    selectedDate: LocalDate,
     scrapList: List<CalendarScrapDetail>,
     onScrapButtonClicked: (Long) -> Unit,
     onInternshipClicked: (CalendarScrapDetail) -> Unit,
@@ -23,7 +22,7 @@ internal fun CalendarScrapList(
     val scrollState = rememberScrollState()
     val topModifier = modifier.then(
         if (!isFromList) {
-            Modifier.verticalScroll(scrollState)
+            Modifier.verticalScroll(scrollState).padding(top = 15.dp)
         } else {
             Modifier
         }

diff --git a/feature/src/main/java/com/terning/feature/calendar/week/CalendarWeekScreen.kt b/feature/src/main/java/com/terning/feature/calendar/week/CalendarWeekScreen.kt
@@ -187,7 +187,7 @@ private fun CalendarWeekScreen(
                     color = Black,
                     modifier = Modifier
                         .fillMaxWidth()
-                        .padding(start = 24.dp, top = 16.dp, bottom = 15.dp)
+                        .padding(start = 24.dp, top = 16.dp)
                 )
 
                 when (uiState.loadState) {
@@ -203,7 +203,6 @@ private fun CalendarWeekScreen(
                     is UiState.Success -> {
                         CalendarWeekSuccess(
                             scrapList = uiState.loadState.data.toImmutableList(),
-                            selectedDate = selectedDate,
                             onScrapButtonClicked = onClickScrapButton,
                             onInternshipClicked = onClickInternship
                         )
@@ -241,10 +240,8 @@ private fun CalendarWeekSuccess(
     scrapList: List<CalendarScrapDetail>,
     onScrapButtonClicked: (Long) -> Unit,
     onInternshipClicked: (CalendarScrapDetail) -> Unit,
-    selectedDate: LocalDate,
 ) {
     CalendarScrapList(
-        selectedDate = selectedDate,
         scrapList = scrapList,
         onScrapButtonClicked = onScrapButtonClicked,
         onInternshipClicked = onInternshipClicked,

diff --git a/feature/src/main/java/com/terning/feature/home/component/HomeUpcomingEmptyFilter.kt b/feature/src/main/java/com/terning/feature/home/component/HomeUpcomingEmptyFilter.kt
@@ -5,6 +5,7 @@ import androidx.compose.foundation.layout.Arrangement
 import androidx.compose.foundation.layout.Column
 import androidx.compose.foundation.layout.fillMaxWidth
 import androidx.compose.foundation.layout.padding
+import androidx.compose.foundation.layout.size
 import androidx.compose.foundation.shape.RoundedCornerShape
 import androidx.compose.material3.Text
 import androidx.compose.runtime.Composable
@@ -45,6 +46,7 @@ fun HomeUpcomingEmptyFilter(
             painter = R.drawable.ic_home_scrap_empty,
             modifier = Modifier
                 .padding(top = 23.dp)
+                .size(44.dp)
         )
         Text(
             text = stringResource(id = R.string.home_upcoming_no_scrap),

diff --git a/feature/src/main/java/com/terning/feature/home/component/HomeUpcomingInternScreen.kt b/feature/src/main/java/com/terning/feature/home/component/HomeUpcomingInternScreen.kt
@@ -27,7 +27,6 @@ import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.draw.clip
 import androidx.compose.ui.graphics.Color
-import androidx.compose.ui.layout.ContentScale
 import androidx.compose.ui.platform.LocalContext
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.unit.dp
@@ -120,7 +119,6 @@ fun HomeUpcomingInternScreen(
                                     .data(homeUpcomingIntern.companyImage)
                                     .build(),
                                 contentDescription = stringResource(id = R.string.home_company_image),
-                                contentScale = ContentScale.Crop,
                                 modifier = Modifier
                                     .height(32.dp)
                                     .aspectRatio(1f)

diff --git a/feature/src/main/res/drawable/ic_home_scrap_empty.png b/feature/src/main/res/drawable/ic_home_scrap_empty.png
diff --git a/feature/src/main/res/drawable/ic_home_scrap_empty.xml b/feature/src/main/res/drawable/ic_home_scrap_empty.xml