[FEAT/#91] 캘린더뷰 / 스크랩 목록 서버통신 #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[FEAT/#72] 소셜 로그인 / 서버통신 로직 구현
…month # Conflicts: # app/src/main/java/com/terning/point/di/DataSourceModule.kt # app/src/main/java/com/terning/point/di/RepositoryModule.kt # app/src/main/java/com/terning/point/di/ServiceModule.kt
leeeyubin
approved these changes
Jul 17, 2024
Comment on lines
+113
to
+117
| year: Int, month: Int | ||
| ) = viewModelScope.launch { | ||
| withContext(Dispatchers.IO) { | ||
| calendarRepository.getScrapMonthList(year, month) | ||
| }.fold( |
There was a problem hiding this comment.
왕,, Dispatchers.IO 까지!! 넘넘 수고 많았다,,,
Comment on lines
142
to
146
| onSuccess = { | ||
| _calendarWeekState.update { currentState -> | ||
| currentState.copy( | ||
| /*loadState = if (it.isNotEmpty()) UiState.Success(it) else UiState.Empty*/ | ||
| loadState = UiState.Success(it) |
Comment on lines
28
to
30
| import kotlinx.coroutines.withContext | ||
| import timber.log.Timber | ||
| import java.time.LocalDate |
Hyobeen-Park
approved these changes
Jul 17, 2024
| fun getScrapMonthList( | ||
| year: Int, month: Int | ||
| ) = viewModelScope.launch { | ||
| withContext(Dispatchers.IO) { |
There was a problem hiding this comment.
우왕 Dispatchers.IO....!!!! 짱이다
| _calendarListState.update { currentState -> | ||
| currentState.copy( | ||
| loadState = if (it.isNotEmpty()) UiState.Success(it) else UiState.Empty | ||
| //loadState = UiState.Success(it) |
| .fillMaxHeight() | ||
| .background(Back) | ||
| ) { | ||
| when (scrapState.loadState) { |
There was a problem hiding this comment.
오... 저도 LazyColumn 안에서 when문으로 확인하는 방식을 고려해봐야겠네요..!! 굿~!~!
There was a problem hiding this comment.
이것보단 Paging 처리하는 방식이 훨씬 나아보이는데 지금은 못하겠네요ㅎㅎ,,
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
default.mp4
📢 To Reviewers