Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT/#88] 회원가입 뷰 / 서버통신 구현 #93

Merged
merged 13 commits into from
Jul 17, 2024
Merged

[FEAT/#88] 회원가입 뷰 / 서버통신 구현 #93

merged 13 commits into from
Jul 17, 2024

Conversation

leeeyubin
Copy link
Member

@leeeyubin leeeyubin commented Jul 16, 2024 •
edited
Loading

⛳️ Work Description

  • 회원가입 뷰 서버통신 구현
  • 서버에서 받은 accessToken, refreshToken 저장
  • 저장한 userId 가져오기
  • 프로필 캐릭터, 회원 이름 서버에서 POST
  • 로그인 뷰 서버통신 수정

📸 Screenshot

Screen_Recording_20240717_180506_Terning-Android.mp4

📢 To Reviewers

  • 회원가입 야무지게 작성했서요

@leeeyubin leeeyubin added FEAT ✨ 새로운 기능 구현 유빈💙 유빈 labels Jul 16, 2024
@leeeyubin leeeyubin self-assigned this Jul 16, 2024
arinming
arinming approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@arinming arinming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

회원가입을 해냄 ㅠ 최구 든든해

core/src/main/java/com/terning/core/designsystem/component/bottomsheet/SignUpBottomSheet.kt Outdated
Comment on lines 43 to 44
var selectedImageIndex by remember { mutableStateOf(-1) }

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mutableIntStateOf 대신 mutableStateOf 사용하신 이유가 있나욤?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오호 급하게 하느라 신경을 못 썼네요! mutableIntStateOf가 더 적절한 것 같아서 바꿔줬습니다!

core/src/main/java/com/terning/core/designsystem/component/textfield/TerningBasicTextField.kt
@@ -140,6 +140,7 @@ fun TerningBasicTextField(
Row(
verticalAlignment = Alignment.CenterVertically,
horizontalArrangement = Arrangement.spacedBy(4.dp),
modifier = modifier.padding(top = 5.dp)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

베이직 텍스트 필드에 top 패딩을 추가하신 이유가 있나욤..?!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

에뮬 돌려보니까 갑자기 패딩이 없어졌더라구요,, 그래서 추가해줬습니다!

data/src/main/java/com/terning/data/datasourceimpl/AuthDataSourceImpl.kt Outdated
Comment on lines 21 to 24
override suspend fun postSignUp(
userId: Long,
request: SignUpRequestDto
): BaseResponse<SignUpResponseDto> = authService.postSignUp(userId, request)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

야무지다.

data/src/main/java/com/terning/data/repositoryimpl/TokenRepositoryImpl.kt Outdated
Comment on lines 23 to 26
override fun getUserId() : Long = terningDataStore.userId

override fun clearInfo() {
terningDataStore.clearInfo()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getUserId는 타입 명시, clearInfo는 안하신 이유가 있나여!?

Copy link
Member Author

@leeeyubin leeeyubin Jul 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clearInfo()는 정보를 지워주는 함수이기 때문에 타입 명시가 필요 없을 것 같아서 안 해줬습니다!

feature/src/main/java/com/terning/feature/onboarding/signup/SignUpViewModel.kt
Comment on lines +84 to +87
).onSuccess { response ->
tokenRepository.setTokens(response.accessToken, response.refreshToken)
tokenRepository.setUserId(response.userId)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아니!!!!진자야무지다

boiledEgg-s
boiledEgg-s approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@boiledEgg-s boiledEgg-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

지인짜 고생많으셨어요!!
얼마 안남으니까 화이팅합시다~

Hyobeen-Park
Hyobeen-Park approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@Hyobeen-Park Hyobeen-Park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

회원가입까지 끝내다니!!!!! 진짜 최고다!!!!

data/src/main/java/com/terning/data/dto/request/SignUpRequestDto.kt
val authType: String
)

fun SignUpRequestModel.toSignUpRequestDto(): SignUpRequestDto =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

함수 앞에 SignUpRequestModel 선언한 이유가 궁금해요!!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SignUpRequestModel의 확장함수이기 때문입니다!!

feature/src/main/java/com/terning/feature/onboarding/signup/SignUpState.kt
@@ -8,10 +8,9 @@ import com.terning.feature.R

data class SignUpState(
val name: String = "",
val character: Int = 0,
val character: Int = -1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 기본값이 -1인 이유가 궁금해요!!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저희가 인덱스 값으로 0~5를 넣어주게 되는데 0을 기본값으로 넣어주면 처음부터 0번 째를 선택한 게 돼버리기 때문에
아무것도 선택하지 않은 상태는 -1로 관리해주려고 했습니다!

@leeeyubin leeeyubin changed the title [FEAT/#88] 회원가입 뷰 / 서버통신 구현 [FEAT/#88] 로그인, 회원가입 뷰 / 서버통신 구현 Jul 17, 2024
@leeeyubin leeeyubin added the FIX 🔨 버그 및 오류 해결 label Jul 17, 2024
@leeeyubin leeeyubin changed the title [FEAT/#88] 로그인, 회원가입 뷰 / 서버통신 구현 [FEAT/#88] 회원가입 뷰 / 서버통신 구현 Jul 17, 2024
@leeeyubin leeeyubin merged commit 3c0a58c into develop Jul 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boiledEgg-s boiledEgg-s boiledEgg-s approved these changes

@Hyobeen-Park Hyobeen-Park Hyobeen-Park approved these changes

@arinming arinming arinming approved these changes

Assignees

@leeeyubin leeeyubin

Labels
FEAT ✨ 새로운 기능 구현 FIX 🔨 버그 및 오류 해결 유빈💙 유빈
Projects
None yet
Milestone
1차 스프린트 서버통신 작업
Development

Successfully merging this pull request may close these issues.

[FEAT] 회원가입 뷰 / 서버통신 구현
4 participants
@leeeyubin @arinming @Hyobeen-Park @boiledEgg-s