Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix warnings in tests #51

Merged
merged 4 commits into from
Feb 22, 2024
Merged

fix warnings in tests #51

merged 4 commits into from
Feb 22, 2024

Conversation

alisterburt
Copy link
Collaborator

@alisterburt alisterburt commented Feb 11, 2024

  • pandas will require pyarrow in the future
  • delim_whitespace is being removed in pd.read_csv

@alisterburt alisterburt changed the title add pyarrow dep to fix tests fix warnings in tests Feb 11, 2024
@alisterburt
Copy link
Collaborator Author

alisterburt commented Feb 22, 2024

hey @jojoelfe - you're right this is the PR that's giving me trouble.

Summary:

  • there's a deprecation in pandas, they're removing delim_whitespace in favour of sep/delimiter``=\s+
  • the behaviour isn't equivalent to delim_whitespace for some of our empty string tests and breaks them

@jojoelfe
Copy link
Collaborator

Hey, just pushed a PR against the pyarrow branch. I think the problem was somewhere else. Before I was resetting columns that contain only NaNs to their original string, but that ment setting a column of type float to a string. Now the whole columns are being replaced, which also replaces the dtype.

@alisterburt
Copy link
Collaborator Author

all green, let's goooo

@alisterburt alisterburt merged commit 6b50943 into main Feb 22, 2024
5 checks passed
@alisterburt alisterburt deleted the pyarrow branch February 22, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants