Allow using plain lyrics #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
meep thanks for the change, could you rebase and add a test file name here? Line 10 in b91c32b |
jgoguen
force-pushed
the
allow-plain-lyrics
branch
from
d0dbf84 to
ad1687e
Compare
Allow the option to use plain lyrics if synced aren't available. They can be fed into a LRC generator for making proper synced lyrics, and for some people plain lyrics is better than no lyrics. Changes the CLI parser to `clap` to make it easier to declare flags and parse the ways someone might pass them. Keeps the existing behaviour as default (`lyricsrs /path/to/music/dir` works and skips plain lyrics) and adds the `--allow-plain` CLI flag to tell `lyricsrs` to write plain lyrics if that's all that's available.
jgoguen
force-pushed
the
allow-plain-lyrics
branch
from
ad1687e to
0f983a4
Compare
techno-disaster
approved these changes
Jul 25, 2024
Co-authored-by: td <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the option to use plain lyrics if synced aren't available. They can be fed into a LRC generator for making proper synced lyrics, and for some people plain lyrics is better than no lyrics.
Changes the CLI parser to
clapto make it easier to declare flags and parse the ways someone might pass them. Keeps the existing behaviour as default (lyricsrs /path/to/music/dirworks and skips plain lyrics) and adds the--allow-plainCLI flag to telllyricsrsto write plain lyrics if that's all that's available.