Skip to content

Commit

Permalink
Do minor changes to cmake files
Browse files Browse the repository at this point in the history
  * MacroLogFeature: Clarify that even if a package is found it will not be used if a feature is disabled
  * Use list append on CMAKE_MODULE_PATH to allow prepending it with toolchain file, which is used with conan recipe.
  * Use target_include_directories over include_directories for bundled zip headers - causes conflict in conan recipe.
  • Loading branch information
joakimono authored and paroj committed Jun 28, 2024
1 parent bb37697 commit 3568f43
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion CMake/Utils/MacroLogFeature.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ MACRO(MACRO_DISPLAY_FEATURE_LOG)
SET(_elist 1)
FILE(READ ${_file} _enabled)
FILE(REMOVE ${_file})
SET(_summary "${_summary}-----------------------------------------------------------------------------\n-- The following external packages were located on your system.\n-- This installation will have the extra features provided by these packages.\n${_enabled}")
SET(_summary "${_summary}-----------------------------------------------------------------------------\n-- The following external packages were located on your system.\n-- This installation will have the extra features provided by these packages, unless disabled.\n${_enabled}")
ENDIF (EXISTS ${_file})

SET(_dlist 0)
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ set(OGRE_VERSION_DASH_SEPARATED "${OGRE_VERSION_MAJOR}-${OGRE_VERSION_MINOR}-${O


# Include necessary submodules
set(CMAKE_MODULE_PATH
list(APPEND CMAKE_MODULE_PATH
"${PROJECT_SOURCE_DIR}/CMake"
"${PROJECT_SOURCE_DIR}/CMake/Utils"
"${PROJECT_SOURCE_DIR}/CMake/Packages"
Expand Down
2 changes: 1 addition & 1 deletion OgreMain/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,6 @@ if (OGRE_CONFIG_ENABLE_ASTC)
endif ()

if (OGRE_CONFIG_ENABLE_ZIP)
include_directories(src/zip)
list(APPEND HEADER_FILES include/OgreZip.h)
list(APPEND SOURCE_FILES src/OgreZip.cpp src/zip/zip.c)

Expand Down Expand Up @@ -172,6 +171,7 @@ generate_export_header(OgreMain
target_include_directories(OgreMain PUBLIC
"$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>"
"$<BUILD_INTERFACE:${PROJECT_BINARY_DIR}/include>"
"$<IF:$<BOOL:OGRE_CONFIG_ENABLE_ZIP>,$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/src/zip>,>"
$<INSTALL_INTERFACE:include/OGRE>
PRIVATE "${OGRE_PROFILING_REMOTERY_PATH}")

Expand Down

0 comments on commit 3568f43

Please sign in to comment.