Skip to content

Commit

Permalink
Sonar issues (#83)
Browse files Browse the repository at this point in the history
* Fix-Sonar Issues

* Fix-Sonar Issues

* Fix-This assertion is unnecessary since it does not change the type of the expression.

* Fix-The object passed as the value prop to the Context provider changes every render. To fix this consider wrapping it in a useMemo hook.

* Fix:Sonar Issues

* Fix:Sonar Issues

* Resolved coderabbitai suggestions

* Fix:Sonar Issues

* Fix:Sonar Issues
  • Loading branch information
vidyaaKhandekar authored Dec 12, 2024
1 parent 93e6bd1 commit 79ecf27
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion src/components/common/input/Select.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ interface Option {

// Define the props for the CustomSelect component
interface CustomSelectProps {
label?: string;
options: Option[];
placeholder?: string;
width?: string;
Expand Down
2 changes: 1 addition & 1 deletion src/components/common/layout/Navbar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ const Navbar: React.FC<{ isMenu?: boolean }> = ({ isMenu = true }) => {
)}
</Box>

<CustomSelect label="EN" options={options} placeholder="EN" />
<CustomSelect options={options} placeholder="EN" />
</Flex>
</Stack>
);
Expand Down

0 comments on commit 79ecf27

Please sign in to comment.