-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ngsi_arcgis_featuretable_sink.md #2327
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -133,7 +135,6 @@ A configuration example could be: | |||
cygnus-ngsi.sinks.arcgis-sink.type = com.telefonica.iot.cygnus.sinks.NGSIArcgisFeatureTableSink | |||
cygnus-ngsi.sinks.arcgis-sink.channel = arcgis-channel | |||
cygnus-ngsi.sinks.arcgis-sink.enable_name_mappings = true | |||
cygnus-ngsi.sinks.arcgis-sink.enable_name_mappings = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicated line in example. NTC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
doc/cygnus-ngsi/flume_extensions_catalogue/ngsi_arcgis_featuretable_sink.md
Outdated
Show resolved
Hide resolved
doc/cygnus-ngsi/flume_extensions_catalogue/ngsi_arcgis_featuretable_sink.md
Outdated
Show resolved
Hide resolved
|
||
Feature table url: https://arcgis.com/{hash}/arcgis/rest/services/vehicles/4wheels | ||
Table's unique field: car | ||
|
||
[Top](#top) | ||
|
||
#### Using Context Broker custom notifications |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be included in ToC above? It seem that four level sections (i.e. ####
) are included in ToC, if I have understood correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title level was wrong, fixed in deb80da
doc/cygnus-ngsi/flume_extensions_catalogue/ngsi_arcgis_featuretable_sink.md
Outdated
Show resolved
Hide resolved
service-path = /4wheels | ||
entity-type = van | ||
|
||
For example, if the Feature table for "van" is `https://arcgis.com/{hash}/arcgis/rest/services/vehicles/van`, the custom notif could be: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest to include the full JSON of the subscription, including the subject
object, so it can be seen how `"type": "van" is used in this case).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition, review the whole document to change:
- van -> Van
- car -> Car
and any other type so we use the current cannonical way of naming entity types (i.e. with first capital letter).
###### result | ||
|
||
Feature table url: https://arcgis.com/{hash}/arcgis/rest/services/vehicles/van | ||
Table's unique field: car |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the result of the second example? Why don't include the result of the first example?
It's a bit weird... maybe we should talk by skype.
…table_sink.md Co-authored-by: Fermín Galán Márquez <[email protected]>
…table_sink.md Co-authored-by: Fermín Galán Márquez <[email protected]>
Remove example section as it is included in the previous section
doc/cygnus-ngsi/flume_extensions_catalogue/ngsi_arcgis_featuretable_sink.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add description to limitations in Arcgis sink