Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/add ngsiv2 ngsild measures payload #779

Merged
merged 42 commits into from
Nov 16, 2023

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Nov 6, 2023

issue #778
Needs telefonicaid/iotagent-node-lib#1521

This solution ignores id and type of provided entities, since a device/group configuration is setting that id and type used before.

Array of entitles are handled as a multiple measure, each entity is a measure.

@AlvaroVega AlvaroVega marked this pull request as ready for review November 7, 2023 15:36
package.json Outdated Show resolved Hide resolved
@fgalan
Copy link
Member

fgalan commented Nov 13, 2023

This solution ignores id and type of provided entities, since a device/group configuration is setting that id and type used before.

Array of entitles are handled as a multiple measure, each entity is a measure.

That's an important pieces of information that could be included in documentation (maybe not in this repo but in the one corresponding to the lib).

@AlvaroVega
Copy link
Member Author

This solution ignores id and type of provided entities, since a device/group configuration is setting that id and type used before.
Array of entitles are handled as a multiple measure, each entity is a measure.

That's an important pieces of information that could be included in documentation (maybe not in this repo but in the one corresponding to the lib).

Done in f631627

docs/usermanual.md Outdated Show resolved Hide resolved
Co-authored-by: Fermín Galán Márquez <[email protected]>
docs/usermanual.md Outdated Show resolved Hide resolved
`ngsiv2` or `ngsild`. In these cases payload is ingested as measure where entity attributes are measure attributes and
`id` and `type` are ignored, since `id` and `type` from device/group configuration provisioned are used.

Examples of these ngsi payloads are:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Examples of these ngsi payloads are:
Examples of these ngsi payloads are (NGSI-v2 batch update format):

docs/usermanual.md Outdated Show resolved Hide resolved
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/usermanual.md Outdated Show resolved Hide resolved
docs/usermanual.md Outdated Show resolved Hide resolved
AlvaroVega and others added 2 commits November 16, 2023 17:28
Co-authored-by: Fermín Galán Márquez <[email protected]>
Comment on lines +14 to +17
"refParkingSite": {
"type": "Relationship",
"value": "urn:ngsi-ld:ParkingSite:santander:daoiz_velarde_1_5"
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that, for the original value represented in NGSI-LD, relationship has object property instead of value. NTC

Copy link
Collaborator

@mapedraza mapedraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mapedraza mapedraza merged commit 488a403 into master Nov 16, 2023
@mapedraza mapedraza deleted the task/add_ngsiv2_ngsild_measures_payload branch November 16, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants