Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usage transport endpoint from group #794

Merged
merged 18 commits into from
Dec 20, 2023

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Dec 15, 2023

Before this PR when a device is provisioned default transport where HTTP if no other one is set at device provisioning time. After this PR default transport could be transport defined at Group Level.

Moreover polling or push behavior has into account possible endpoint defined at Group level.

  • Update doc
  • Add tests (about command groups for HTTP and MQTT transports)
  • Remove local implementation of findOrCreate

Needs telefonicaid/iotagent-node-lib#1543 and
telefonicaid/iotagent-node-lib#1547

@AlvaroVega AlvaroVega requested a review from fgalan December 19, 2023 16:15
@AlvaroVega AlvaroVega marked this pull request as ready for review December 19, 2023 16:15
CHANGES_NEXT_RELEASE Outdated Show resolved Hide resolved
@fgalan
Copy link
Member

fgalan commented Dec 20, 2023

Twin PR telefonicaid/iotagent-ul#656

Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit 436f5a1 into master Dec 20, 2023
7 checks passed
@fgalan fgalan deleted the task/usage_transport_endpoint_from_group2 branch December 20, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants