Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests about last measure #848

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Jan 10, 2025

This PR adds a full test for branch telefonicaid/iotagent-node-lib#1670

@AlvaroVega AlvaroVega changed the title add tests about last measure [WIP] add tests about last measure Jan 10, 2025
@AlvaroVega
Copy link
Member Author

This PR needs #849

@AlvaroVega AlvaroVega changed the title [WIP] add tests about last measure add tests about last measure Jan 14, 2025
@AlvaroVega AlvaroVega requested a review from fgalan January 14, 2025 09:50
@fgalan
Copy link
Member

fgalan commented Jan 14, 2025

Should a twin PR be done in IOTA-UL (not sure if that agent could be considered now obsolete...)?

@AlvaroVega
Copy link
Member Author

Should a twin PR be done in IOTA-UL (not sure if that agent could be considered now obsolete...)?

In this case no one test for iota-ul is expected since is a bit obsolete.

@fgalan
Copy link
Member

fgalan commented Jan 14, 2025

This PR needs #849

Merged. This PR should be synched with master.

Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit 188b127 into master Jan 15, 2025
5 of 6 checks passed
@fgalan fgalan deleted the task/add_test_about_last_measure branch January 15, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants