EDIT rename major and minor version properties appropiately

telefonicaid · Jul 16, 2014 · 26bcf18 · 26bcf18
1 parent 4d6f992
commit 26bcf18
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/ios/Hybridge/Hybridge/HYBBridge.h b/ios/Hybridge/Hybridge/HYBBridge.h
@@ -23,12 +23,12 @@
 /**
  Returns the native bridge major version.
  */
-+ (NSInteger)version;
++ (NSInteger)majorVersion;
 
 /**
  Returns the native bridge minor version.
  */
-+ (NSInteger)versionMinor;
++ (NSInteger)minorVersion;
 
 /**
  Sets the active bridge.

diff --git a/ios/Hybridge/Hybridge/HYBBridge.m b/ios/Hybridge/Hybridge/HYBBridge.m
@@ -86,11 +86,11 @@ + (void)initialize {
     }
 }
 
-+ (NSInteger)version {
++ (NSInteger)majorVersion {
     return 1;
 }
 
-+ (NSInteger)versionMinor {
++ (NSInteger)minorVersion {
     return 2;
 }
 
@@ -144,7 +144,7 @@ - (NSString *)prepareWebView:(UIWebView *)webView {
     NSArray *events = @[HYBEventPause, HYBEventResume, HYBEventMessage, HYBEventReady];
     NSString *eventsString = [NSString hyb_JSONStringWithObject:events];
 
-    NSString *javascript = [NSString stringWithFormat:kFormat, @([[self class] version]), @([[self class] versionMinor]), actionsString, eventsString];
+    NSString *javascript = [NSString stringWithFormat:kFormat, @([[self class] majorVersion]), @([[self class] minorVersion]), actionsString, eventsString];
     return [webView stringByEvaluatingJavaScriptFromString:javascript];
 }
 

diff --git a/ios/Hybridge/HybridgeTests/HYBBridgeTests.m b/ios/Hybridge/HybridgeTests/HYBBridgeTests.m
@@ -31,11 +31,11 @@ - (void)tearDown {
 }
 
 - (void)testVersion {
-    XCTAssertEqual((NSInteger)1, [HYBBridge version], @"should return the right version");
+    XCTAssertEqual((NSInteger)1, [HYBBridge majorVersion], @"should return the right major version");
 }
 
 - (void)testVersionMinor {
-    XCTAssertEqual((NSInteger)2, [HYBBridge versionMinor], @"should return the right minor version");
+    XCTAssertEqual((NSInteger)2, [HYBBridge minorVersion], @"should return the right minor version");
 }
 
 - (void)testActiveBridge {